Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(UI): manually uploading subtitles dialog with a long file name doesn't wrap or work break #2448

Closed
boydaihungst opened this issue Apr 9, 2024 · 6 comments

Comments

@boydaihungst
Copy link

Describe the bug
Manually uploading subtitles dialog with long file name, which has each words separated by a special character, doesn't wrap. Please see the image below.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Bazarr" website
  2. Click on Wanted episode/movie
  3. Click on any Episode or Movie
  4. Click on manual upload button. Then select the long name sub.
  5. Check the manual import dialog.

Expected behavior
The file name should be wrap or break word, e.g:

a.really.longggggggg...01.srt
a.really.longggggggg...S01E01.srt
# Or break word
a.really.longggggggg
gggggggggggggggg
ggggggggg.name.w
ithout.whitespace.01.srt

We should somehow show the number in the file name, so that when users import multiple files, they will know which episode number it is.

Screenshots
Screenshot_20240409-104910_Firefox_Nightly

Software (please complete the following information):

  • Bazarr: 1.4.3-beta.15
  • Radarr version: 5.3.6.8612
  • Sonarr version: 4.0.3.1413
  • OS: Linux Ubuntu Server 23.04 (kernel-6.2.0-39-generic-x86_64-with-glibc2.37)
  • Python Version: 3.11.4

Additional context
Example subfile name for testing: a.really.longgggggggggggggggggggggggggggggggg.name.without.whitespace.01.srt
a.really.longgggggggggggggggggggggggggggggggg.name.without.whitespace.S01E01.srt

@morpheus65535
Copy link
Owner

Should be fixed now. Let use know if it's not the case.

@boydaihungst
Copy link
Author

boydaihungst commented Apr 17, 2024

@morpheus65535 it break UI of other places on mobile.
Single tv show page:
Screenshot_20240417-090617_Firefox_Nightly

Wanted page:
Screenshot_20240417-090629_Firefox_Nightly

History page:
Screenshot_20240417-091108_Firefox_Nightly

@morpheus65535
Copy link
Owner

@boydaihungst yeah you're right. Thanks for reporting.

@anderson-oki I think we're gonna need a more specific fix for upload modal.

@anderson-oki
Copy link

anderson-oki commented Apr 17, 2024

Yeah let me open a PR only for that modal, and perhaps we can manually apply where needed manually. And revert the global modals.

@anderson-oki
Copy link

@morpheus65535 This should do the trick #2459. Sorry about that.

@morpheus65535
Copy link
Owner

@morpheus65535 This should do the trick #2459. Sorry about that.

Not a big deal, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants