Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix when getting Python bundle path #1854

Merged
merged 1 commit into from
May 29, 2022

Conversation

alexreg
Copy link
Contributor

@alexreg alexreg commented May 28, 2022

Amendment to PR #1831 that handles virtual environments properly.

@alexreg
Copy link
Contributor Author

alexreg commented May 28, 2022

Incidentally, are you aware that the development branch version does not work? When making an HTTP request, one always gets the following in the log.

2022-05-28 03:43:03,300 - app.app                          (29f87f000) :  ERROR (app:1457) - Exception on / [GET]                                                                                       

@morpheus65535
Copy link
Owner

Incidentally, are you aware that the development branch version does not work? When making an HTTP request, one always gets the following in the log.

2022-05-28 03:43:03,300 - app.app                          (29f87f000) :  ERROR (app:1457) - Exception on / [GET]                                                                                       

Works fine for me. Do you have your dev environment with node setup properly?

@alexreg
Copy link
Contributor Author

alexreg commented May 28, 2022

@morpheus65535 It's possible something is broken on my system, but it certainly used to work before. What's the proper setup? And can we enable debug logs? (To know what exact exception occurred.)

Sorry, I probably should have created another issue for this, since it's independent of this PR as far as I can tell.

@morpheus65535
Copy link
Owner

@morpheus65535 It's possible something is broken on my system, but it certainly used to work before. What's the proper setup? And can we enable debug logs? (To know what exact exception occurred.)

Sorry, I probably should have created another issue for this, since it's independent of this PR as far as I can [tell.]

(https://github.com/morpheus65535/bazarr/blob/master/frontend/README.md)

I'll wait for this to be confirm before merging.

@alexreg
Copy link
Contributor Author

alexreg commented May 29, 2022

@morpheus65535 That's fine. The only small change in this PR is to use the actual location of the Python installation, in case you're using a virtual environment. If you're not using a virtual environment, there's no difference. But by all means, have a test for yourself.

@alexreg alexreg mentioned this pull request May 29, 2022
@morpheus65535 morpheus65535 merged commit c501098 into morpheus65535:development May 29, 2022
@alexreg
Copy link
Contributor Author

alexreg commented May 29, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants