Fix animetosho encoding parser #2476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Modifications on vendored modules must be made upstream first: https://github.com/tkarabela/pysubs2 |
Crazy mistake here. I cant believe i didnt noticed i was changing an external dependency. |
|
Haha no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is not directly related to AnimeTosho tho, but that's the one issue identified on #2470. It could cover other providers as well.
There are subtitles where the layer is
''empty instead of 0. You can find an example of Delicious in Dungeon Season 1 Episode 17. There are several more that follows the same pattern.