Add defineBy*File' variant to client that takes a Q FilePath #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlistairB
changed the title
This enables using utilities such as https://hackage.haskell.org/package/file-embed-0.0.13.0/docs/Data-FileEmbed.html#v:makeRelativeToProject which can be used to work around file path issues when using multi package projects.
AlistairB
force-pushed
the
client-allow-qfilepath
branch
from
aca6876
to
a7d73f2
Compare
|
@nalchevanidze I made an attempt. I haven't worked with haddock docs much. Let me know what you think thanks. |
nalchevanidze
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using utilities such as https://hackage.haskell.org/package/file-embed-0.0.13.0/docs/Data-FileEmbed.html#v:makeRelativeToProject
which can be used to work around file path issues when using multi package projects.
Specifically, if I run
stack repl subprojectwhich usesdefineByDocumentFileit fails as the path is calculated differently viastack replas compared to when you run the code or run it with tests. This issue also breaks haskell language server, as it relies onstack replas well.This changes enables using
makeRelativeToProjectwhich will hopefully make everything work.Currently I am just putting this up to test that it does fix it.Indeed this does fix the issue.This is ready for review.