Feat/implement retry logic #8
Conversation
| } catch (e) { | ||
| if (retries++ < (maxRetries ?? DEFAULT_RETRIES)) { | ||
| // Wait for a random time before retrying. | ||
| const delay = Math.ceil(Math.random() * (retryDelay ?? RETRY_DELAY)); |
There was a problem hiding this comment.
I don't get why waiting for a random time instead of just the max time (retryDelay ?? RETRY_DELAY). It makes things a little bit non-deterministic.
There was a problem hiding this comment.
this is to resolve throughput issues on a node. If you retry x queries where the issue is that these x issues are sent at the same time, using a random time is the only way to solve that.
NB: the delay of an http query is already non deterministic
There was a problem hiding this comment.
I don't see how this solves the node throughput issue. It seems to be worsening it by globally shortening the time between each failed request (compared to waiting the max time).
There was a problem hiding this comment.
There was a problem hiding this comment.
The implementation corresponds to the Option 3 simple retries povided by Alchemy
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description of change
Closes: #7
Pull-Request Checklist
Fixes #0000