Append all signatures and sort them via script #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhusson
approved these changes
Apr 28, 2023
MerlinEgalite
requested changes
Apr 28, 2023
adhusson
reviewed
Apr 28, 2023
adhusson
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Tests should be written
I ran a manual test using this tx:
TO=0x4976fb03C32e5B8cfe2b6cCB31c09Ba78EBaBa41 FOUNDRY_FORK_BLOCK_NUMBER=15358278 make hashwhich outputs
dataHash = 0x5288bdf645f343409e55df21ba0888106bc4a2592ce90456889149ba545a6332just like what was submitted to the safe at the time of tx (nonce 29, included in block 15358279)