Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss stale period #11

Closed
MerlinEgalite opened this issue Oct 4, 2023 · 3 comments
Closed

Discuss stale period #11

MerlinEgalite opened this issue Oct 4, 2023 · 3 comments
Labels
🧐 question Further information is requested

Comments

@MerlinEgalite
Copy link
Contributor

As a reference:

On my side I'd be in favor of implementing a stale period check of 36 hours or 48 hours. This is a safe margin I think. We can safely say that after this period the price feed is stale

@MerlinEgalite MerlinEgalite added the 🧐 question Further information is requested label Oct 4, 2023
@MathisGD
Copy link
Contributor

MathisGD commented Oct 4, 2023

I don't think that the check should be implemented, because:

  • lenders can do it on their own and leave the market when they think that a price is stale.
  • This is supposed to be enforced by Chainlink, and if we don't trust Chainlink we should add other checks
  • I think that it is very low probability that Chainlink on purpose shuts down a feed without making it revert

@Rubilmax
Copy link
Contributor

Rubilmax commented Oct 4, 2023

it is very low probability that Chainlink on purpose shuts down a feed without making it revert

is this claim backed by a discussion with their team? (in any case, I don't think we should consider whether they are going to revert or silently make it stale)

@MerlinEgalite
Copy link
Contributor Author

We should at least add a comment IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧐 question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants