Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At least decrease the nb of reports #1285

Merged
merged 3 commits into from
Sep 11, 2022
Merged

At least decrease the nb of reports #1285

merged 3 commits into from
Sep 11, 2022

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented Sep 9, 2022

Pull Request

Issue(s) fixed

This pull request fixes #to-complete

or

This pull request fixes:

  • #to-complete
  • #to-complete
  • ...

@Rubilmax Rubilmax requested a review from a team September 9, 2022 13:18
@github-actions
Copy link

github-actions bot commented Sep 10, 2022

Morpho-aave-v2 gas impacts (eth-mainnet)

Generated at commit: 2085f0b0bc65d278dceaa82f0c8fd604f3c402fd, compared to commit: 622a800b2d2b4653ce808e18eaaf7c7bb7a118d1

🧾 Summary

Contract Method Avg (+/-) %
ExitPositionsManager liquidateLogic
withdrawLogic
+11,703 ❌
+1,479 ❌
+9.32%
+0.74%
Morpho borrow(address,uint256)
borrow(address,uint256,uint256)
createMarket
initialize
liquidate
rewardsManager
setIncentivesVault
setRewardsManager
setTreasuryVault
supply(address,uint256)
withdraw(address,uint256)
+11,642 ❌
+13,234 ❌
+4 ❌
+5 ❌
+5,716 ❌
+1 ❌
+1 ❌
+1 ❌
+2 ❌
+760 ❌
+1,392 ❌
+2.90%
+6.40%
+0.00%
+0.00%
+8.18%
+0.16%
+0.00%
+0.00%
+0.01%
+0.23%
+0.72%
EntryPositionsManager borrowLogic
supplyLogic
+12,227 ❌
+734 ❌
+3.22%
+0.22%
RewardsManagerOnMainnetAndAvalanche initialize
updateUserAssetAndAccruedRewards
+2 ❌
+83 ❌
+0.00%
+0.27%
InterestRatesManager updateIndexes +16 ❌ +0.12%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ExitPositionsManager 3,682,512 (+59,483) liquidateLogic
withdrawLogic
1,193 (0)
724 (0)
0.00%
0.00%
137,240 (+11,703)
202,373 (+1,479)
+9.32%
+0.74%
61,305 (+25,156)
121,707 (0)
+69.59%
0.00%
315,387 (+10,890)
2,111,229 (0)
+3.58%
0.00%
11 (0)
80 (0)
Morpho 3,436,193 (0) borrow(address,uint256)
borrow(address,uint256,uint256)
createMarket
initialize
liquidate
rewardsManager
setIncentivesVault
setRewardsManager
setTreasuryVault
supply(address,uint256)
withdraw(address,uint256)
4,098 (0)
13,646 (0)
2,847 (0)
3,663 (0)
4,288 (0)
404 (0)
2,695 (0)
2,631 (0)
2,673 (0)
4,074 (0)
4,034 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
413,250 (+11,642)
219,955 (+13,234)
208,111 (+4)
230,107 (+5)
75,609 (+5,716)
626 (+1)
23,713 (+1)
21,593 (+1)
23,521 (+2)
335,799 (+760)
194,332 (+1,392)
+2.90%
+6.40%
+0.00%
+0.00%
+8.18%
+0.16%
+0.00%
+0.00%
+0.01%
+0.23%
+0.72%
396,371 (+10,851)
211,719 (+13,564)
204,995 (0)
231,146 (0)
9,695 (0)
404 (0)
23,878 (0)
21,814 (0)
23,856 (0)
201,523 (0)
125,660 (0)
+2.81%
+6.85%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
1,907,541 (+10,909)
469,945 (+13,564)
226,840 (0)
231,146 (0)
323,443 (+10,890)
2,404 (0)
23,878 (0)
21,814 (0)
23,856 (0)
1,920,021 (0)
2,118,782 (0)
+0.58%
+2.97%
0.00%
0.00%
+3.48%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
246 (+1)
41 (0)
1,097 (+5)
219 (+1)
22 (0)
2,009 (+7)
220 (+1)
221 (+1)
222 (+1)
504 (+2)
85 (0)
EntryPositionsManager 2,854,882 (+59,477) borrowLogic
supplyLogic
490 (0)
737 (0)
0.00%
0.00%
392,332 (+12,227)
335,791 (+734)
+3.22%
+0.22%
264,178 (+11,002)
203,195 (0)
+4.35%
0.00%
1,903,564 (+10,909)
1,916,048 (0)
+0.58%
0.00%
280 (+1)
499 (+2)
RewardsManagerOnMainnetAndAvalanche 1,133,544 (0) initialize
updateUserAssetAndAccruedRewards
2,742 (0)
2,117 (0)
0.00%
0.00%
92,716 (+2)
30,720 (+83)
+0.00%
+0.27%
93,129 (0)
26,959 (0)
0.00%
0.00%
93,129 (0)
78,353 (0)
0.00%
0.00%
219 (+1)
1,127 (+2)
InterestRatesManager 803,602 (0) updateIndexes 634 (0) 0.00% 12,949 (+16) +0.12% 14,185 (0) 0.00% 51,585 (0) 0.00% 2,715 (+4)

Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, love that it shows the seed !

@Rubilmax Rubilmax merged commit ee6a252 into dev Sep 11, 2022
@Rubilmax Rubilmax deleted the ci/less-reports branch September 11, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants