Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor liquidation on deprecated market #1305

Merged
merged 8 commits into from
Sep 23, 2022
Merged

Refactor liquidation on deprecated market #1305

merged 8 commits into from
Sep 23, 2022

Conversation

MerlinEgalite
Copy link
Contributor

Pull Request

Issue(s) fixed

This pull request fixes #1303

@MerlinEgalite MerlinEgalite requested a review from a team September 21, 2022 15:02
@MerlinEgalite MerlinEgalite marked this pull request as ready for review September 21, 2022 15:46
@morpho-org morpho-org deleted a comment from github-actions bot Sep 21, 2022
@morpho-org morpho-org deleted a comment from github-actions bot Sep 21, 2022
@morpho-org morpho-org deleted a comment from github-actions bot Sep 21, 2022
MathisGD
MathisGD requested changes Sep 21, 2022
View reviewed changes
contracts/aave-v2/ExitPositionsManager.sol Outdated Show resolved Hide resolved
contracts/aave-v2/ExitPositionsManager.sol Show resolved Hide resolved
contracts/aave-v2/ExitPositionsManager.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite requested a review from a team September 22, 2022 07:48
Rubilmax
Rubilmax reviewed Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree w Mathis, I think we have the opportunity to move the deprecated market-liquidation-related logic inside liquidationAllowed

@morpho-org morpho-org deleted a comment from github-actions bot Sep 22, 2022
@morpho-org morpho-org deleted a comment from github-actions bot Sep 22, 2022
@morpho-org morpho-org deleted a comment from github-actions bot Sep 22, 2022
Rubilmax
Rubilmax approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner!

MathisGD
MathisGD approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morpho-org morpho-org deleted a comment from github-actions bot Sep 22, 2022
@morpho-org morpho-org deleted a comment from github-actions bot Sep 22, 2022
@morpho-org morpho-org deleted a comment from github-actions bot Sep 22, 2022
@MerlinEgalite MerlinEgalite changed the base branch from main to dev September 23, 2022 08:21
@MerlinEgalite MerlinEgalite merged commit cf7efc4 into dev Sep 23, 2022
@MerlinEgalite MerlinEgalite deleted the refactor/liquidation-deprecated-mkt branch September 23, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MathisGD MathisGD MathisGD approved these changes

Assignees
No one assigned
Labels
👻 aave-v2 👻 aave-v3 🟢 compound 🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instant liquidation on deprecated markets
4 participants
@MerlinEgalite @Rubilmax @pakim249CAL @MathisGD