Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Clean tests #0 #1342

Merged
merged 1 commit into from
Oct 7, 2022
Merged

✅ Clean tests #0 #1342

merged 1 commit into from
Oct 7, 2022

Conversation

MerlinEgalite
Copy link
Contributor

This PRs removes wrong computation functions

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Morpho-aave-v3 gas impacts (avalanche-mainnet)

Generated at commit: 7c97574c0ee1e1a0bc4d8aac104e62ea28164f31, compared to commit: 81afc946e08deced6437f2345f6e6abea547748a

🧾 Summary

Contract Method Avg (+/-) %
Morpho p2pBorrowIndex
p2pSupplyIndex		 +1 ❌
-1 ✅		 +0.13%
-0.12%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Morpho 3,497,474 (0) p2pBorrowIndex
p2pSupplyIndex		 582 (0)
624 (0)		 0.00%
0.00%		 763 (+1)
809 (-1)		 +0.13%
-0.12%		 582 (0)
624 (0)		 0.00%
0.00%		 2,582 (0)
2,624 (0)		 0.00%
0.00%		 110 (-1)
108 (+1)

@MerlinEgalite MerlinEgalite changed the title ✅ Clean tests ✅ Clean tests #0 Oct 6, 2022
@MerlinEgalite MerlinEgalite marked this pull request as ready for review October 6, 2022 09:53
@MerlinEgalite MerlinEgalite requested a review from a team October 6, 2022 09:53
Rubilmax
Rubilmax approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

test-foundry/aave-v3/TestRepay.t.sol Show resolved Hide resolved
@MerlinEgalite MerlinEgalite requested a review from a team October 6, 2022 17:29
@MerlinEgalite MerlinEgalite requested a review from a team October 7, 2022 06:52
@MerlinEgalite MerlinEgalite merged commit 7d4584a into main Oct 7, 2022
@MerlinEgalite MerlinEgalite deleted the test/clean-0 branch October 7, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

Assignees
No one assigned
Labels
🏹 fuzzing 🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MerlinEgalite @Rubilmax @pakim249CAL