Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformized litteral formatting #1496

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Uniformized litteral formatting #1496

merged 2 commits into from
Dec 4, 2022

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax linked an issue Nov 30, 2022 that may be closed by this pull request
[R&D review] Style: formatting percentage litteral values #1479
Closed
3 tasks
MerlinEgalite
MerlinEgalite approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MathisGD
MathisGD approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some in aave-v3 but I guess that's out of scope right ?

@Rubilmax
Copy link
Collaborator Author

Rubilmax commented Dec 1, 2022

There are still some in aave-v3 but I guess that's out of scope right ?

Aren't we dropping support for aave-v3?

@MerlinEgalite
Copy link
Contributor

There are still some in aave-v3 but I guess that's out of scope right ?

Aren't we dropping support for aave-v3?

That's the reason deleting it would avoid confusion

@Rubilmax
Copy link
Collaborator Author

Rubilmax commented Dec 1, 2022

There are still some in aave-v3 but I guess that's out of scope right ?

Aren't we dropping support for aave-v3?

That's the reason deleting it would avoid confusion

@QGarchery ?

@Rubilmax Rubilmax merged commit f228847 into upgrade-lens-0 Dec 4, 2022
@Rubilmax Rubilmax deleted the fix/litteral-formatting branch December 4, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MathisGD MathisGD MathisGD approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees
No one assigned
Labels
👻 aave-v2 🟢 compound
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R&D review] Style: formatting percentage litteral values
4 participants
@Rubilmax @MerlinEgalite @pakim249CAL @MathisGD