Removed comments

morpho-org · Dec 15, 2022 · ad7d519 · ad7d519
1 parent e91e8bc
commit ad7d519
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 46 deletions.
diff --git a/src/compound/SupplyVault.sol b/src/compound/SupplyVault.sol
@@ -134,7 +134,7 @@ contract SupplyVault is ISupplyVault, SupplyVaultBase {
         if (rewardsIndexDiff > 0) {
             unclaimed += balanceOf(_user).mulWadDown(rewardsIndexDiff);
             userRewardsData.unclaimed = unclaimed.safeCastTo128();
-            userRewardsData.index = _newRewardsIndex.safeCastTo128(); // TODO: why was this line outside the if?
+            userRewardsData.index = _newRewardsIndex.safeCastTo128();
 
             emit Accrued(_user, _newRewardsIndex, unclaimed);
         }

diff --git a/test/aave-v2/TestSupplyVault.t.sol b/test/aave-v2/TestSupplyVault.t.sol
@@ -168,21 +168,6 @@ contract TestSupplyVault is TestSetupVaults {
         vaultSupplier1.redeemVault(daiSupplyVault, shares + 1);
     }
 
-    // TODO: fix this test by using updated indexes in previewMint
-    // function testShouldMintCorrectAmountWhenMorphoPoolIndexesOutdated() public {
-    //     uint256 amount = 10_000 ether;
-
-    //     vaultSupplier1.depositVault(daiSupplyVault, amount);
-
-    //     vm.roll(block.number + 100_000);
-    //     vm.warp(block.timestamp + 1_000_000);
-
-    //     uint256 assets = vaultSupplier2.mintVault(daiSupplyVault, amount);
-    //     uint256 shares = vaultSupplier2.withdrawVault(daiSupplyVault, assets);
-
-    //     assertEq(shares, amount, "unexpected redeemed shares");
-    // }
-
     function testShouldDepositCorrectAmountWhenMorphoPoolIndexesOutdated() public {
         uint256 amount = 10_000 ether;
 

diff --git a/test/aave-v3/TestSupplyVault.t.sol b/test/aave-v3/TestSupplyVault.t.sol
@@ -798,21 +798,6 @@ contract TestSupplyVault is TestSetupVaults {
         // In the end, vaultSupplier1 got 2 * X rewards while vaultSupplier2 got 3 * X
     }
 
-    // TODO: fix this test by using updated indexes in previewMint
-    // function testShouldMintCorrectAmountWhenMorphoPoolIndexesOutdated() public {
-    //     uint256 amount = 10_000 ether;
-
-    //     vaultSupplier1.depositVault(daiSupplyVault, amount);
-
-    //     vm.roll(block.number + 100_000);
-    //     vm.warp(block.timestamp + 1_000_000);
-
-    //     uint256 assets = vaultSupplier2.mintVault(daiSupplyVault, amount);
-    //     uint256 shares = vaultSupplier2.withdrawVault(daiSupplyVault, assets);
-
-    //     assertEq(shares, amount, "unexpected redeemed shares");
-    // }
-
     function testShouldDepositCorrectAmountWhenMorphoPoolIndexesOutdated() public {
         uint256 amount = 10_000 ether;
 

diff --git a/test/compound/TestSupplyVault.t.sol b/test/compound/TestSupplyVault.t.sol
@@ -469,21 +469,6 @@ contract TestSupplyVault is TestSetupVaults {
         assertApproxEqAbs(uint256(userReward1_1), userReward1_2, 1);
     }
 
-    // TODO: fix this test by using updated indexes in previewMint
-    // function testShouldMintCorrectAmountWhenMorphoPoolIndexesOutdated() public {
-    //     uint256 amount = 10_000 ether;
-
-    //     vaultSupplier1.depositVault(daiSupplyVault, amount);
-
-    //     vm.roll(block.number + 100_000);
-    //     vm.warp(block.timestamp + 1_000_000);
-
-    //     uint256 assets = vaultSupplier2.mintVault(daiSupplyVault, amount);
-    //     uint256 shares = vaultSupplier2.withdrawVault(daiSupplyVault, assets);
-
-    //     assertEq(shares, amount, "unexpected redeemed shares");
-    // }
-
     function testShouldDepositCorrectAmountWhenMorphoPoolIndexesOutdated() public {
         uint256 amount = 10_000 ether;