Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVL-01M: Potential Point of Concern #49

Closed
Tracked by #37
Rubilmax opened this issue Aug 4, 2022 · 3 comments
Closed
Tracked by #37

SVL-01M: Potential Point of Concern #49

Rubilmax opened this issue Aug 4, 2022 · 3 comments

Comments

@Rubilmax
Copy link
Contributor

Rubilmax commented Aug 4, 2022

https://omniscia.io/reports/morpho-labs-tokenized-vaults/manual-review/SupplyVault-SVL#SVL-01M
@MerlinEgalite MerlinEgalite mentioned this issue Aug 8, 2022
Closed
25 tasks
@MerlinEgalite
Copy link
Contributor

Not sure what they mean by the false flag... @Rubilmax @pakim249CAL any idea?

@Rubilmax
Copy link
Contributor Author

Rubilmax commented Aug 8, 2022

Not sure what they mean by the false flag... @Rubilmax @pakim249CAL any idea?

I think what they name "false" flag is the false boolean we pass as option to trade reward tokens for $MORPHO tokens (which we never do, hence the false flag)

IMO we should conduct an internal audit of this call specifically but don't go further with this issue which is only a warning

@MerlinEgalite
Copy link
Contributor

ok let's acknowledge this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rubilmax @MerlinEgalite