Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/examples #101

Merged
merged 8 commits into from
May 9, 2023
Merged

Test/examples #101

merged 8 commits into from
May 9, 2023

Conversation

saeedehsp
Copy link
Collaborator

@saeedehsp saeedehsp commented Jan 25, 2023

closes #xxxx

  • tests added
  • all tests pass
  • documentation
  • AUTHORS entry
  • Changelog entry

📚 Documentation preview 📚: https://morphocut--101.org.readthedocs.build/en/101/

@moi90
Copy link
Member

moi90 commented Jan 27, 2023

Thanks for your first pull request!

A few things:

  • Typing: As long as we support Python 3.7 and 3.8, my understanding is that we need to use typing.Tuple. https://stackoverflow.com/a/39458225/1116842
  • Why is it better to use ExitStack instead of nullcontext?
  • Can you please investigate the failing test?
  • I can see how relative paths in the examples fit more environments (e.g. non-Unix). I think it would be better to write to local *_out folders (inside the examples directory, e.g. flowcam_out). These need to be added to .gitignore as well.

Copy link
Member

@moi90 moi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

.gitignore Outdated Show resolved Hide resolved
examples/flowcam.py Show resolved Hide resolved
tests/test_torch.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #101 (8e67dbd) into master (9671f0c) will increase coverage by 0.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   79.32%   80.07%   +0.74%     
==========================================
  Files          27       27              
  Lines        2225     2223       -2     
  Branches      383      381       -2     
==========================================
+ Hits         1765     1780      +15     
+ Misses        381      366      -15     
+ Partials       79       77       -2     
Impacted Files Coverage Δ
src/morphocut/batch.py 87.75% <100.00%> (ø)

... and 5 files with indirect coverage changes

@moi90
Copy link
Member

moi90 commented Mar 3, 2023

Please add your name in AUTHORS.rst (if you like). Then I'll merge :)

@moi90 moi90 merged commit 95f8124 into morphocut:master May 9, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants