feat: Virtual frames and stitching #108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes to ecotaxa and core are unrelated to the topic of this pull request, can you please revert them? |
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 79.48% 80.03% +0.54%
==========================================
Files 27 28 +1
Lines 2223 2434 +211
Branches 382 445 +63
==========================================
+ Hits 1767 1948 +181
- Misses 379 393 +14
- Partials 77 93 +16
|
|
I merged the master branch and now the changes look clean. |
moi90
changed the title
moi90
reviewed
Apr 28, 2023
tests/test_stitch.py
Outdated
|
|
||
| assert isinstance(region.sum(axis=0), np.ndarray) | ||
|
|
||
| with pytest.raises(IndexError, match="Invalid key: .* Only slice and tuple of slice are allowed."): |
There was a problem hiding this comment.
You shouldn't test _validate_key (which is private) but __getitem__ and __setitem__ which make use of it.
|
Thanks for this huge chunk of work! (Please excuse my brevity, the baby demands my attention;)) |
moi90
reviewed
Apr 29, 2023
- Coverage for Region.__array_ufunc__ - Use np.testing.assert_equal
|
I made a few changes to increase coverage. I think after you addressed my remark above and created the changelog entry, this PR can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #xxxx
馃摎 Documentation preview 馃摎: https://morphocut--108.org.readthedocs.build/en/108/