Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for some ModelBuilder options #5

Merged
merged 8 commits into from
Aug 23, 2019

Conversation

dfyx
Copy link
Contributor

@dfyx dfyx commented Aug 16, 2019

Fixes #4

Note that this is a breaking change as default file names no longer include the namespace.

@dfyx
Copy link
Contributor Author

dfyx commented Aug 16, 2019

The remaining codeclimate prolems are re-reported because of minor changes to lines with existing problems. They should probably be fixed by creating abstract base classes FileManagerBase and SerializerBase. I'll leave that for another pull request to keep this one focused on the actual changes to behavior.

@dfyx dfyx mentioned this pull request Aug 16, 2019
@dfyx
Copy link
Contributor Author

dfyx commented Aug 19, 2019

I added some more minor changes to support even more special cases that I encountered in my legacy data.

@morrisjdev morrisjdev merged commit a574260 into morrisjdev:master Aug 23, 2019
@morrisjdev
Copy link
Owner

Thank you for your work.
I will upload the new version soon

KuraiAndras added a commit to KuraiAndras/FileContextCore that referenced this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelBuilder configuration gets ignored
2 participants