Bug fix for SortedMap. When setting a value for a key that already ex…

…isted, the value was not updated.
morrisonlevi · Feb 6, 2013 · bec537e · bec537e
1 parent 0d8aea9
commit bec537e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/Ardent/BinarySearchTree.php b/src/Ardent/BinarySearchTree.php
@@ -72,6 +72,8 @@ protected function addRecursive($element, BinaryTree $node = NULL) {
             $node->setLeft($this->addRecursive($element, $node->getLeft()));
         } elseif ($comparisonResult > 0) {
             $node->setRight($this->addRecursive($element, $node->getRight()));
+        } else {
+            $node->setValue($element);
         }
 
         return $node;

diff --git a/test/Ardent/SortedMapTest.php b/test/Ardent/SortedMapTest.php
@@ -31,6 +31,19 @@ function testOffsetSet() {
         $this->assertCount(3, $map);
     }
 
+    /**
+     * @depends testOffsetSet
+     */
+    function testOffsetSetAlreadySet() {
+        $map = new SortedMap();
+        $map[1] = 1;
+        $map[1] = 0;
+
+        $expected = 0;
+        $actual = $map[1];
+        $this->assertEquals($expected, $actual);
+    }
+
     /**
      * @depends testOffsetSet
      * @covers \Ardent\SortedMap::offsetUnset