Update web-interceptor.js #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing getMatchingMock method so that it returns a matching mock only if it's active
|
Thanks! I think this might have been a bug I've fixed in the master branch and didn't pull into next. |
|
I think I have 2.0.7 If you play around with the two mocks that point to http://500tech.github.io/mimic/api/content |
|
Thank you so much for catching this! |
morsdyce
pushed a commit
that referenced
this pull request
Oct 20, 2018
…red active status of the mock (#262) When having 2 or more mocks on the same route, we tried to get the first matching mock, however we did not check if the mock is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing getMatchingMock method so that it returns a matching mock only if it's active