Fix warnings (#321)

* Fix warnings * Fix deprecation warnings
mortbopet · Nov 24, 2023 · f673e59 · f673e59
1 parent 2a042c9
commit f673e59
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 9 deletions.
diff --git a/external/fancytabbar/fancytabbar.cpp b/external/fancytabbar/fancytabbar.cpp
@@ -176,7 +176,8 @@ void FancyTabBar::paintEvent(QPaintEvent *event) {
  */
 void FancyTabBar::mousePressEvent(QMouseEvent *event) {
   if (event->button() == Qt::LeftButton) {
-    qint32 ret = getTabIndexByPoint(event->x(), event->y());
+    qint32 ret =
+        getTabIndexByPoint(event->position().x(), event->position().y());
 
     // If non of the tabs is clicked dont change the curent activeIndex.
     if (ret != -1)
@@ -196,7 +197,7 @@ void FancyTabBar::mousePressEvent(QMouseEvent *event) {
  */
 void FancyTabBar::mouseMoveEvent(QMouseEvent *event) {
   QWidget::mouseMoveEvent(event);
-  hower = getTabIndexByPoint(event->x(), event->y());
+  hower = getTabIndexByPoint(event->position().x(), event->position().y());
   update();
 }
 
@@ -207,7 +208,8 @@ void FancyTabBar::mouseMoveEvent(QMouseEvent *event) {
  */
 void FancyTabBar::enterEvent(QEnterEvent *event) {
   QEnterEvent *enterEvent = static_cast<QEnterEvent *>(event);
-  hower = getTabIndexByPoint(enterEvent->x(), enterEvent->y());
+  hower = getTabIndexByPoint(enterEvent->position().x(),
+                             enterEvent->position().y());
   update();
 }
 

diff --git a/src/cachesim/chartlinemarker.cpp b/src/cachesim/chartlinemarker.cpp
@@ -57,7 +57,7 @@ void ChartLineMarker::move(const QPointF &center) {
         qobject_cast<QValueAxis *>(m_chart->axes(Qt::Horizontal).constFirst());
 
     // Note: we assume that the points are in a sorted order!
-    const auto &points = m_series->pointsVector();
+    const auto &points = m_series->points();
     const QPointF chartPos = m_chart->mapToValue(center);
     auto iter =
         std::lower_bound(points.begin(), points.end(), chartPos.x(),

diff --git a/src/processors/interface/ripesprocessor.h b/src/processors/interface/ripesprocessor.h
@@ -262,11 +262,11 @@ class RipesProcessor {
    */
   virtual void resetProcessor() = 0;
 
-  /*
+  /**
    * @brief vcdTrace
    * Enables VCD tracing of the processor model, if supported by the simulator.
    */
-  virtual void vcdTrace(bool enable, const QString &filename){};
+  virtual void vcdTrace(bool, const QString &){};
 
   /**
    * @brief clock

diff --git a/src/wasmSupport.h b/src/wasmSupport.h
@@ -6,11 +6,14 @@ namespace Ripes {
 
 // Disable a widget if we are running in a wasm environment.
 template <typename T>
-inline void disableIfWasm(T *widget) {
 #ifdef __EMSCRIPTEN__
+inline void disableIfWasm(T *widget) {
   widget->setEnabled(false);
-#endif
 }
+#else
+inline void disableIfWasm(T *) {
+}
+#endif
 
 // Disables a list of widgets if we are running in a wasm environment.
 template <typename TList>
@@ -19,4 +22,4 @@ inline void disableIfWasm(TList widgets) {
     disableIfWasm(widget);
 }
 
-} // namespace Ripes
+} // namespace Ripes