Transaction Split Tests #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @morukele , I saw this when I wanted to create secrets on my own fork. 
But with that, the actions still fail on my own fork. Also, I sent you an email regarding the meeting.
Thanks
|
|
Hi @Lilit0x Your hint was correct, GitHub doesn't let PRs have access to the repo secrets. I have updated the main branch with a potential fix for this issue. With this fix, the tests are still going to fail when you make a PR, but when I re-run it, it should pass. Could you get the latest copy of the code and open another PR? |
|
Okay, doing that now. |
|
The test passes! So you can write all the tests and I will have a way to verify them now! |
|
@Lilit0x All tests pass and now merging with the main. Thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test suites for the transaction split API