Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuke YAHP #1512

Merged
merged 13 commits into from Oct 27, 2022
Merged

Nuke YAHP #1512

merged 13 commits into from Oct 27, 2022

Conversation

hanlint
Copy link
Contributor

@hanlint hanlint commented Sep 9, 2022 •
edited

This PR removes YAHP from our codebase.

@hanlint hanlint marked this pull request as draft September 9, 2022 18:59
@hanlint hanlint changed the title [WIP] Nuke YAHP Nuke YAHP Oct 26, 2022
@hanlint hanlint marked this pull request as ready for review October 26, 2022 17:59
@hanlint hanlint requested a review from dakinggg October 26, 2022 18:01
bandish-shah
bandish-shah approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's roll!

mvpatel2000
mvpatel2000 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eracah
eracah approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess examples/glue/* will stay as is and research will modify it?

@dakinggg
Copy link
Contributor

@eracah @hanlint no, examples/glue should be removed as well.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Bandish Shah and others added 3 commits October 27, 2022 11:33
knighton
knighton approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@knighton knighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@bandish-shah bandish-shah merged commit 3f557fa into mosaicml:dev Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knighton knighton knighton approved these changes

@eracah eracah eracah approved these changes

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@dakinggg dakinggg dakinggg approved these changes

@bandish-shah bandish-shah bandish-shah approved these changes

@dskhudia dskhudia Awaiting requested review from dskhudia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hanlint @dakinggg @knighton @eracah @mvpatel2000 @bandish-shah