Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unregister engine for memory cleanup #1769

Merged
merged 2 commits into from Dec 1, 2022
Merged

unregister engine for memory cleanup #1769

merged 2 commits into from Dec 1, 2022

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Dec 1, 2022 •
edited

What does this PR do?

Fixes memory not being freed with object deletion.

Experiment training resnet twice in same python process
Before:
image
After:
image

What issue(s) does this change relate to?

CO-1443

dakinggg
dakinggg approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be a good idea to get someone with more context on why this was added in the first place to review?

@mvpatel2000
Copy link
Contributor Author

LGTM, might be a good idea to get someone with more context on why this was added in the first place to review?

Working with Hanlin to figure out why we need atexit. I want to remove if possible, but this will patch for now

@mvpatel2000 mvpatel2000 merged commit 8042873 into mosaicml:dev Dec 1, 2022
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/atexit-unregister branch December 1, 2022 01:54
bmosaicml pushed a commit to bmosaicml/composer that referenced this pull request Dec 13, 2022
@mvpatel2000 @bmosaicml
unregister (mosaicml#1769)
d9a0319
@mvpatel2000 mvpatel2000 changed the title unregister unregister engine for memory cleanup Dec 13, 2022
@mvpatel2000 mvpatel2000 mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvpatel2000 @dakinggg