Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deprecation warning for Fused LayerNorm #1789

Merged
merged 11 commits into from Dec 6, 2022

Conversation

nik-mosaic
Copy link
Contributor

@nik-mosaic nik-mosaic commented Dec 6, 2022

Add Deprecation warning for Fused LayerNorm. It will be removed in 0.13 and replaced by Low Precision LayerNorm.

@nik-mosaic nik-mosaic marked this pull request as ready for review December 6, 2022 18:27
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left comment to update warning to clearly specify deprecation warning

composer/algorithms/fused_layernorm/fused_layernorm.py Outdated Show resolved Hide resolved
nik-mosaic and others added 2 commits December 6, 2022 10:47
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
@nik-mosaic nik-mosaic merged commit 4a7426b into mosaicml:dev Dec 6, 2022
@nik-mosaic nik-mosaic deleted the nikhil/deprecate-fln branch December 6, 2022 22:23
bmosaicml pushed a commit to bmosaicml/composer that referenced this pull request Dec 13, 2022
Fused LayerNorm will be removed shortly, replaced by Low Precision LayerNorm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants