Parameterized Dockerfiles #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added timeout to the hparams for initialize_process_group. The default of 30 minutes was too long for failing tests, which prevents one from getting any meaningful log. 2. In cleanup(), using `os.killpg` to terminate DDP subprocesses instead of just kill(). 3. In cleanup(), attempting a `sigterm` before resorting to a `sigkill()` 5 seconds later. Graceful cleanup is preferred!
Fixed escape sequence
Tests were failing when composer was not installed with `-e`, causing the yamls to be not found and included
ravi-mosaicml
changed the base branch from
ravi/log_debug_in_tests
to
ravi/ddp_enhancements
ravi-mosaicml
requested review from
ajaysaini725,
anisehsani,
bandish-shah,
jbloxham and
Averylamp
1. Documented Makefile 2. Removed build matrix (for now) from the docke readme 3. Fixed pillow-simd 4. Renamed user to mosaicml 5. Updated pytorch minimum version to 1.9
bandish-shah
approved these changes
Nov 9, 2021
coryMosaicML
pushed a commit
to coryMosaicML/composer
that referenced
this pull request
Feb 23, 2022
Added a Dockerfile to build a pytorch image. Parameterized the Dockerfile for composer, which extends the Pytorch image Updated the Makefile to use the new parameterized Dockerfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfileto build a pytorch image.Dockerfilefor composer, which extends thePytorchimageMakefileto use the new parameterized Dockerfiles