Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dataloader.py #102

Merged
merged 2 commits into from
May 11, 2023
Merged

Update dataloader.py #102

merged 2 commits into from
May 11, 2023

Conversation

nelsontkq
Copy link
Contributor

@nelsontkq nelsontkq commented May 10, 2023

Error says local should be set if remote is set

`local` should be set if `remote` is set
@vchiley vchiley requested a review from alextrott16 May 11, 2023 18:32
Copy link
Contributor

@alextrott16 alextrott16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@vchiley vchiley merged commit a3eed9b into mosaicml:main May 11, 2023
6 checks passed
@nelsontkq nelsontkq deleted the patch-1 branch May 12, 2023 07:56
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
Incorporates the batch sizing logic from `examples/llm/main.py` into `examples/bert/main.py` and changes the associated YAMLs to work with that change.

This PR also includes a minor refactor of some of the config utilities.
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
`local` should be set if `remote` is set

Co-authored-by: Vitaliy Chiley <6439018+vchiley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants