Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llama attention patch #1036

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Fix llama attention patch #1036

merged 3 commits into from
Mar 14, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Mar 14, 2024

Missed in the latest release (its deprecated so probably won't do a patch, but fixing on main anyway)

Tests pass locally: 10 passed, 12 deselected, 12 warnings in 7.35s
Full train run comparison:
Screenshot 2024-03-14 at 4 53 24 PM

@dakinggg dakinggg requested a review from irenedea March 14, 2024 23:53
@dakinggg dakinggg marked this pull request as ready for review March 14, 2024 23:53
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dakinggg dakinggg merged commit cffd75e into mosaicml:main Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants