Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config_moe_args.py #1104

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Update config_moe_args.py #1104

merged 1 commit into from
Apr 10, 2024

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Apr 10, 2024

Replace create_process_group_ranks fn with distributed.new_group

see here
Ran 500 steps, new version did marginally better
Screenshot 2024-04-09 at 7 10 45 PM

@vchiley vchiley merged commit 17f8aeb into main Apr 10, 2024
9 checks passed
vchiley added a commit to vchiley/composer that referenced this pull request Apr 10, 2024
vchiley added a commit to mosaicml/composer that referenced this pull request Apr 10, 2024
vchiley added a commit that referenced this pull request Apr 12, 2024
vchiley added a commit that referenced this pull request Apr 12, 2024
vchiley added a commit that referenced this pull request Apr 12, 2024
#1111 needed to revert #1104 because the #1104 PR caused issues. Removing TODO and marking Jira with wont-do
@vchiley vchiley mentioned this pull request Apr 12, 2024
vchiley added a commit that referenced this pull request Apr 12, 2024
#1111 needed to revert #1104 because the #1104 PR caused issues. Removing TODO and marking Jira with wont-do
staghado pushed a commit to lightonai/composer that referenced this pull request Apr 13, 2024
staghado pushed a commit to lightonai/composer that referenced this pull request Apr 13, 2024
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
#1111 needed to revert #1104 because the #1104 PR caused issues. Removing TODO and marking Jira with wont-do
j316chuck pushed a commit to mosaicml/composer that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants