First initialize dist with gloo #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
reviewed
Apr 24, 2024
irenedea
approved these changes
Apr 24, 2024
|
This might break on >300 GPUs per @sandeep-krishnamurthy-db's point on GLOO's limitations. Can you doubel check max size for GLOO? |
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
mvpatel2000
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
CC: @bigning this is roughly what im thinking for control plane except we wouldn't destroy it and would name it something else
dakinggg
added a commit
to dakinggg/llm-foundry
that referenced
this pull request
Apr 25, 2024
This reverts commit 76f74b6.
dakinggg
added a commit
that referenced
this pull request
Apr 25, 2024
dakinggg
added a commit
to dakinggg/llm-foundry
that referenced
this pull request
Apr 25, 2024
…aicml#1139)" This reverts commit 4aef5de.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with the first nccl barrier, where the timeout does not properly apply. It does apply correctly to a gloo barrier though. So we add a gloo barrier at the start to make sure all ranks are alive, and then proceed with the normal process group intialization.
Run with this that runs successfully:
gloo-baseline-1-cAcvEBRun with this change and a rank sleeping in the gloo section (does timeout):
gloo-messed-up-no-gloo-2-CZw9ru(on a7616ea)Run with this change and a rank sleeping in the nccl section (does not timeout):
gloo-messed-up-5-HB6gOH(on ac258b9)