Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to hf_generate #116

Merged
merged 5 commits into from
May 12, 2023
Merged

Add features to hf_generate #116

merged 5 commits into from
May 12, 2023

Conversation

alextrott16
Copy link
Contributor

Please ignore the branch name. FSDP was planned for this, along with other features, but this PR will just add the other features:

  • Extra generate control knobs
  • Sweep over multiple combinations of generate param values
  • Prompts from text files
  • Setting maximum batch size

Copy link
Member

@abhi-mosaic abhi-mosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few minor comments but otherwise looks good! Thanks for adding optional batching support too.

scripts/inference/hf_generate.py Show resolved Hide resolved
scripts/inference/hf_generate.py Show resolved Hide resolved
scripts/inference/hf_generate.py Outdated Show resolved Hide resolved
alextrott16 and others added 2 commits May 12, 2023 11:47
Co-authored-by: Abhi Venigalla <77638579+abhi-mosaic@users.noreply.github.com>
@alextrott16 alextrott16 merged commit bb61301 into main May 12, 2023
6 checks passed
@hanlint hanlint deleted the alex/hf-generate-fsdp branch May 26, 2023 19:49
bmosaicml added a commit that referenced this pull request Jun 6, 2023
* Add initial support for ICL evaluation (e.g. LAMBADA, PIQA). 
* Can be used for offline eval, or measured live during training with Composer.
bmosaicml pushed a commit that referenced this pull request Jun 6, 2023
Adds QOL features to hf_generate:
- Extra generate control knobs
- Sweep over multiple combinations of generate param values
- Prompts from text files
- Setting maximum batch size
---------
Co-authored-by: Abhi Venigalla <77638579+abhi-mosaic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants