Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring dataloader into registries. #1165

Merged
merged 8 commits into from
May 2, 2024
Merged

refactoring dataloader into registries. #1165

merged 8 commits into from
May 2, 2024

Conversation

ShashankMosaicML
Copy link
Contributor

@ShashankMosaicML ShashankMosaicML commented May 2, 2024 •
edited

Training run for text dataloader before and after refactoring overlap:

  1. Loss :Screenshot 2024-05-02 at 1 08 06 PM
  2. MFU : Screenshot 2024-05-02 at 1 08 27 PM
  3. Memory : Screenshot 2024-05-02 at 1 08 40 PM

Training run for finetuning dataloader with streaming dataset before and after refactoring overlap:

  1. Loss :
Screenshot 2024-05-02 at 1 10 46 PM 2. MFU : Screenshot 2024-05-02 at 1 11 23 PM 3. Memory : Screenshot 2024-05-02 at 1 10 30 PM

Training run for finetuning dataloader with huggingface dataset before and after refactoring overlap:

  1. Loss :
Screenshot 2024-05-02 at 1 12 16 PM
  1. MFU :
Screenshot 2024-05-02 at 1 12 26 PM
  1. Memory :
Screenshot 2024-05-02 at 1 12 47 PM

@ShashankMosaicML ShashankMosaicML marked this pull request as ready for review May 2, 2024 20:13
dakinggg
dakinggg approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

llmfoundry/data/text_data.py Outdated Show resolved Hide resolved
llmfoundry/registry.py Outdated Show resolved Hide resolved
llmfoundry/registry.py Outdated Show resolved Hide resolved
@ShashankMosaicML ShashankMosaicML enabled auto-merge (squash) May 2, 2024 22:27
@ShashankMosaicML ShashankMosaicML enabled auto-merge (squash) May 2, 2024 22:34
@ShashankMosaicML ShashankMosaicML merged commit 3b82735 into mosaicml:main May 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@irenedea irenedea Awaiting requested review from irenedea

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

@vchiley vchiley Awaiting requested review from vchiley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShashankMosaicML @dakinggg