Set pad_token_id to tokenizer.pad_token_id if not set on command line #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the The attention mask and the pad token id were not set. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results. Setting `pad_token_id` to `eos_token_id`:0 for open-end generation. message that appears every time in the chat loop. Tested in the mosaicml/pytorch docker container.
patrickhwood
changed the title
alextrott16
reviewed
May 12, 2023
There was a problem hiding this comment.
Thanks @patrickhwood!
@samhavens I'll defer approval to you because you know the script better, but the change here is what we do in hf_generate.py and it doesn't seem to cause any trouble.
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
… of the (#118) The attention mask and the pad token id were not set. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results. Setting `pad_token_id` to `eos_token_id`:0 for open-end generation. message that appears every time in the chat loop. Tested in the mosaicml/pytorch docker container. Co-authored-by: Pat Wood <Pat.Wood@efi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hf_chat.py program emits this warning message before each chat response:
The attention mask and the pad token id were not set. As a consequence, you may observe unexpected behavior. Please pass your input's
attention_maskto obtain reliable results.Setting
pad_token_idtoeos_token_id:0 for open-end generation.Fixed by setting pad_token_id to tokenizer.eos_token_id if not set on the command line.