clean up dataset conversion readme #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
May 18, 2023
dakinggg
reviewed
May 18, 2023
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
alextrott16
reviewed
May 19, 2023
There was a problem hiding this comment.
The finetuning stuff looks good to me, so I'm approving that part. But, as mentioned in a comment. I have caught some QOL stuff with the preprocessing function that I think needs to be addressed in a separate PR. That will require me to edit the finetuning section, but what you added here is a very useful starting point for that.
dakinggg
approved these changes
May 22, 2023
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
bmosaicml
pushed a commit
that referenced
this pull request
Jun 8, 2023
* clean up dataset conversion readme * Update scripts/data_prep/README.md Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com> * Update scripts/data_prep/README.md Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com> * addresses feedback on PR * add links to relevant proprocessing functions * add link to streaming --------- Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up existing readme and adds finetuning dataset example