Rename datasets to avoid hf conflict #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
approved these changes
May 19, 2023
This was referenced May 19, 2023
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
* upgrade to torch 13 * remove cd * fix tests, force 113
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
* rename datasets to avoid hf conflict * consistent HF datasets import --------- Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
datasets.pyfile has:which leads to circular imports. To reproduce the error, run:
This PR renames
datasets.py->data. Moreover, external scripts should import from the top-level packagellmfoundry.data.Fixes: #137 and #127