Adding different device intialization to eval #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
reviewed
Jul 18, 2023
| "Reverting to `cfg.model.init_device='cpu'`.") | ||
| model_cfg.init_device = 'cpu' | ||
| if model_cfg.init_device == 'meta': | ||
| init_context = init_empty_weights() |
There was a problem hiding this comment.
Hey there! I noticed that when running the quick start example here: https://docs.mosaicml.com/projects/mcli/en/latest/guides/first_llm.html the run fails because init_empty_weights is not defined
----------Begin global rank 7 STDERR----------
╭───────────────────── Traceback (most recent call last) ──────────────────────╮
│ /llm-foundry/scripts/train/train.py:328 in <module> │
│ │
│ 325 │ │ yaml_cfg = om.load(f) │
│ 326 │ cli_cfg = om.from_cli(args_list) │
│ 327 │ cfg = om.merge(yaml_cfg, cli_cfg) │
│ ❱ 328 │ main(cfg) │
│ 329 │
│ │
│ /llm-foundry/scripts/train/train.py:203 in main │
│ │
│ 200 │ │ cfg.pop('fsdp_config') │
│ 201 │ │ fsdp_config = None │
│ 202 │ │
│ ❱ 203 │ init_context = process_init_device(cfg.model, fsdp_config) │
│ 204 │ │
│ 205 │ # build tokenizer │
│ 206 │ tokenizer = build_tokenizer(cfg.tokenizer) │
│ │
│ /llm-foundry/llmfoundry/utils/config_utils.py:70 in process_init_device │
│ │
│ 67 │ │ │ │ "Reverting to `cfg.model.init_device='cpu'`.") │
│ 68 │ │ │ model_cfg.init_device = 'cpu' │
│ 69 │ │ if model_cfg.init_device == 'meta': │
│ ❱ 70 │ │ │ init_context = init_empty_weights() │
│ 71 │ │ if model_cfg.init_device == 'mixed': │
│ 72 │ │ │ if fsdp_config is None: │
│ 73 │ │ │ │ raise NotImplementedError( │
╰──────────────────────────────────────────────────────────────────────────────╯
NameError: name 'init_empty_weights' is not defined
Just wanted to flag it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
mixedinitialization for eval.py in LLM-Foundry. Run onr1z1here:mpt30b-chat-hf-eval-r1z1-hs6a7u