Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix boolean for reentrant setting #500

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix boolean for reentrant setting #500

merged 2 commits into from
Aug 2, 2023

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Aug 2, 2023 •
edited

@dakinggg dakinggg requested a review from vchiley August 2, 2023 08:37
vchiley
vchiley approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@vchiley vchiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vchiley vchiley merged commit 05c6055 into mosaicml:main Aug 2, 2023
10 checks passed
@dakinggg dakinggg deleted the finetune-hang branch September 9, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchiley vchiley vchiley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dakinggg @vchiley