Convert to DataSpec and add token counts that include padding #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
reviewed
Oct 16, 2023
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
alextrott16
approved these changes
Oct 16, 2023
jjanezhang
added a commit
that referenced
this pull request
Oct 20, 2023
fixed typing for mosaicmllogger fixed formatting, moved logging logic out of logger builder removed callback moved all to train.py Convert to DataSpec and add token counts that include padding (#676) Add support for automatically registering models to UC at the end of training (#618) removed callback from init removed callback from init removed generate callback sorted imports formatting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes DataLoader to DataSpec in order to provide a non default token counting function that takes into account padding.
Two runs that are the same except that one of them counts tokens with padding and one counts them without.
