Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "completion" alias for response key #771

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Dec 1, 2023

No description provided.

@dakinggg dakinggg marked this pull request as ready for review December 1, 2023 23:51
@dakinggg dakinggg enabled auto-merge (squash) December 2, 2023 00:19
Copy link
Contributor

@nancyhung nancyhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, comment about adding to the test case. approving to unblock

tests/test_dataloader.py Outdated Show resolved Hide resolved
aspfohl and others added 2 commits December 1, 2023 17:04
* Add eval loader to eval script

* small input tests

* updates

* fix typing and formatting

* fixes, add tests

* remove circular dependency

* tests pass

* nits + small fixes

* add metrics at the end, refactor to put icl/gauntlet as helpers

* NOT

* metrics instead of models, add unit tests

* Move tests into directories

* add copyright to inits

* fix relative paths

* fixes

* revert gauntlet test change

* Support inputs_embeds (mosaicml#687)

* support inputs_embeds

* update tests to test inputs_embeds

* make iids optional inputs to fwd

* remove check for both iids and inputs_embeds

in MPTForCausalLM. It is checked in the base model, and it is actually a common practice to pass both during autoregressive generation. Embeds are used first, then once the kvcache is nonempty, iids are used instead

* reorder kwargs

* add more tests

* fix device merge artifact in test_model.oy

* fix generate test

* yapf

* Better error message when test does not complete (mosaicml#769)

* run script tests first

* comment out

* ascripts -> scripts

* bad dirs

* try this

* hacks

* add a note about a_scripts

---------

Co-authored-by: Sam Havens <sam@mosaicml.com>
@dakinggg dakinggg enabled auto-merge (squash) December 2, 2023 01:06
@dakinggg dakinggg merged commit b2e4b0e into mosaicml:main Dec 2, 2023
10 checks passed
@dakinggg dakinggg deleted the completion branch December 11, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants