Add generic flatten imports to HF checkpointer #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
approved these changes
Dec 21, 2023
b-chu
force-pushed
the
hf-checkpointer
branch
2 times, most recently
from
4f8b7df
to
571c8e7
Compare
b-chu
force-pushed
the
hf-checkpointer
branch
2 times, most recently
from
e0caf5d
to
8dbcdbe
Compare
b-chu
force-pushed
the
hf-checkpointer
branch
from
8dbcdbe
to
f9d7caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using HF checkpointer from another repo, the checkpointer does not correctly flatten all imports. This change allows the user to specify the imports that need to be flattened.
No existing behavior has changed.
Tested using a different repo.