Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align GLU implementation with LLaMa #829

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Dec 31, 2023

Align LLM-Foundry GLU implementation with LLaMa implementation
ie

self.down_proj(self.act(self.gate_proj(x)) * self.up_proj(x))

instead of

self.down_proj(self.act(self.up_proj(x)) * self.gate(x))

Additionally, with #805, we are no longer constricted to using gelus. Therefore it's no longer GeGLU, but ANY_ACT_FN_GLU, so I'm changing the name to generic GLU.

@vchiley vchiley merged commit 1ac5c4b into mosaicml:main Jan 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants