Fixed helper connected callback (#388)

test/auth.js

@@ -771,7 +771,7 @@ test('failed authentication does not disconnect other client with same clientId'
   })
 })
 
-test('unauthorized connection should not unregister the correct one', function (t) {
+test('unauthorized connection should not unregister the correct one with same clientId', function (t) {
   t.plan(2)
 
   var broker = aedes({
@@ -780,11 +780,14 @@ test('unauthorized connection should not unregister the correct one', function (
         callback(null, true)
       } else {
         const error = new Error()
-        error.returnCode = 1
+        error.returnCode = 4
         callback(error, false)
       }
     }
   })
+  broker.on('clientError', function (client, err) {
+    t.equal(broker.connectedClients, 1, 'my-client still connected')
+  })
 
   connect(setup(broker), {
     clientId: 'my-client',
@@ -796,7 +799,7 @@ test('unauthorized connection should not unregister the correct one', function (
       username: 'unauthorized'
     }, function () {
       // other unauthorized connection with the same clientId should not unregister the correct one.
-      t.equal(broker.connectedClients, 1, 'my-client still connected')
+      t.fail('unauthorized should not connect')
     })
   })
 })

test/helper.js

@@ -60,7 +60,7 @@ function connect (s, opts, connected) {
     // setup also needs to return first
     if (packet.cmd !== 'connack') {
       setImmediate(this.push.bind(this, packet))
-    } else if (connected) {
+    } else if (connected && packet.returnCode === 0) {
       setImmediate(connected, packet)
     }
     cb()