New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Readme #355
Updated Readme #355
Conversation
- [aedes-persistence-level](https://github.com/moscajs/aedes-persistence-level): LevelDB persistence for Aedes | ||
- [aedes-persistence-nedb](https://github.com/ovhemert/aedes-persistence-nedb#readme): NeDB persistence for Aedes | ||
- [aedes-logging](https://github.com/moscajs/aedes-logging): Logging module for Aedes, based on Pino | ||
- [aedes-stats](https://github.com/moscajs/aedes-stats): Stats for Aedes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably include links to the mqemitter equivalents as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I will add missings mqemitters links. COuld you check also if all the ticks on the table of features are correct? I have a '?' on bridge as I don't understand what it means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme has '?' on bridge. what does it mean ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what i mean to highlight is - aedes either supports bridge or not. so documentation should represent that accurately.
Just for info. I will always submit PRs and I will let you review and merge them once you decide they are good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
… On 11 Feb 2020, at 20:25, qwertangel ***@***.***> wrote:
@qwertangel commented on this pull request.
In README.md:
> @@ -475,6 +502,16 @@ You can subscribe on the following `$SYS` topics to get client presence:
- `$SYS/+/disconnect/clients` - will inform about client disconnections.
The payload will contain the `clientId` of the connected/disconnected client
+## Plugins
+
+- [aedes-persistence](https://github.com/moscajs/aedes-persistence): In-memory implementation of an Aedes persistence
+ - [aedes-persistence-mongodb](https://github.com/moscajs/aedes-persistence-mongodb): MongoDB persistence for Aedes
+ - [aedes-persistence-redis](https://github.com/moscajs/aedes-persistence-redis): Redis persistence for Aedes
+ - [aedes-persistence-level](https://github.com/moscajs/aedes-persistence-level): LevelDB persistence for Aedes
+ - [aedes-persistence-nedb](https://github.com/ovhemert/aedes-persistence-nedb#readme): NeDB persistence for Aedes
+- [aedes-logging](https://github.com/moscajs/aedes-logging): Logging module for Aedes, based on Pino
+- [aedes-stats](https://github.com/moscajs/aedes-stats): Stats for Aedes
readme has '?' on bridge. what does it mean ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Actually nope
Daniel
… On 11 Feb 2020, at 21:45, qwertangel ***@***.***> wrote:
@qwertangel commented on this pull request.
In README.md:
> @@ -475,6 +502,16 @@ You can subscribe on the following `$SYS` topics to get client presence:
- `$SYS/+/disconnect/clients` - will inform about client disconnections.
The payload will contain the `clientId` of the connected/disconnected client
+## Plugins
+
+- [aedes-persistence](https://github.com/moscajs/aedes-persistence): In-memory implementation of an Aedes persistence
+ - [aedes-persistence-mongodb](https://github.com/moscajs/aedes-persistence-mongodb): MongoDB persistence for Aedes
+ - [aedes-persistence-redis](https://github.com/moscajs/aedes-persistence-redis): Redis persistence for Aedes
+ - [aedes-persistence-level](https://github.com/moscajs/aedes-persistence-level): LevelDB persistence for Aedes
+ - [aedes-persistence-nedb](https://github.com/ovhemert/aedes-persistence-nedb#readme): NeDB persistence for Aedes
+- [aedes-logging](https://github.com/moscajs/aedes-logging): Logging module for Aedes, based on Pino
+- [aedes-stats](https://github.com/moscajs/aedes-stats): Stats for Aedes
what i mean to highlight is - aedes either supports bridge or not. so documentation should represent that accurately.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
so a 'X' instead of '?' would be more appropriate in documentation ? |
Yes, initially when I made this PR I didn’t know if it was or not that is why I placed that question mark
… On 11 Feb 2020, at 22:10, qwertangel ***@***.***> wrote:
so a 'X' instead of '?' would be more appropriate in documentation ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
No description provided.