Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme #355

Merged
merged 11 commits into from Jan 21, 2020
Merged

Updated Readme #355

merged 11 commits into from Jan 21, 2020

Conversation

robertsLando
Copy link
Member

No description provided.

- [aedes-persistence-level](https://github.com/moscajs/aedes-persistence-level): LevelDB persistence for Aedes
- [aedes-persistence-nedb](https://github.com/ovhemert/aedes-persistence-nedb#readme): NeDB persistence for Aedes
- [aedes-logging](https://github.com/moscajs/aedes-logging): Logging module for Aedes, based on Pino
- [aedes-stats](https://github.com/moscajs/aedes-stats): Stats for Aedes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably include links to the mqemitter equivalents as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I will add missings mqemitters links. COuld you check also if all the ticks on the table of features are correct? I have a '?' on bridge as I don't understand what it means

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme has '?' on bridge. what does it mean ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what i mean to highlight is - aedes either supports bridge or not. so documentation should represent that accurately.

README.md Show resolved Hide resolved
@robertsLando
Copy link
Member Author

Just for info. I will always submit PRs and I will let you review and merge them once you decide they are good

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit f62a343 into moscajs:master Jan 21, 2020
@robertsLando
Copy link
Member Author

robertsLando commented Feb 11, 2020 via email

@robertsLando
Copy link
Member Author

robertsLando commented Feb 11, 2020 via email

@carefulcomputer
Copy link

so a 'X' instead of '?' would be more appropriate in documentation ?

@robertsLando
Copy link
Member Author

robertsLando commented Feb 11, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants