Added a proper catch block for handling errors

[gnought]

@mcollina Is it better to add .catch() block rather than try/catch?
any differences?

[mcollina]

the try catch will save some promise allocation. However there is a risk that the catch part in the try/catch throw, resulting in an unhandled rejection.

This code is fine, it's just for tests.

[gnought]

Thanks for the explanation. Could we stick into a practise and merge it into the master branch?

[mcollina]

I would make this a promise and use await.

[gnought]

  function finish () {
    return new Promise((resolve, reject) => {
      broker.close()
      resolve(t.end)
    })
  }
  (async () => {
    await Promise.all([msg(s, 100, packet1), msg(s, 200, packet2)])
    await finish()
  })().catch(
    (error) => {
      t.fail(error)
    }
  )

Is the above what you mean? :)

[gnought]

or should it be like this?

  (async () => {
    await Promise.all([msg(s, 100, packet1), msg(s, 200, packet2)])
  })().catch(
    (error) => {
      t.fail(error)
    }
  ).finally(finish)

[mcollina]

I mean

const immediate = promisify(setImmediate)

[gnought]

awesome!. I haven't seen we could promisify setImmediate.
Like this?

  const immediate = util.promisify(setImmediate)

  ;(async () => {
    await Promise.all([msg(s, 100, packet1), msg(s, 200, packet2)])
    await immediate().then(() => {
      broker.close()
      t.end()
    })
  })().catch(
    (error) => {
      t.fail(error)
    }
  )

[gnought]

I would make this a promise and use await.

May we know what the differences are?

[mcollina]

Suggested change

	await immediate().then(() => {
	await immediate()

[gnought]

awesome. You are a great teacher!

[mcollina]

lgtm

[github-actions]

Pull Request Test Coverage Report for Build 16556a6f9c59eee72db902f6900eaad9d2fdd6d1-PR-385

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.08%) to 95.802%

---

Totals
Change from base Build 3e0af1fca5dc2b606acea4e8a2faf10d05e01970:	0.08%
Covered Lines:	821
Relevant Lines:	842

---

💛 - Coveralls