Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aedes-protocol-decoder plugin support #395

Merged
merged 5 commits into from Feb 4, 2020
Merged

aedes-protocol-decoder plugin support #395

merged 5 commits into from Feb 4, 2020

Conversation

robertsLando
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 3, 2020

Pull Request Test Coverage Report for Build af85da5ce0b6a69d996dc91aa16800cbfd668ca8-PR-395

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 94.491%
Files with Coverage Reduction New Missed Lines %
lib/client.js 4 93.29%
Totals Coverage Status
Change from base Build 26473cddde3092a8d5fa8becafea7c4134d83fe4: -0.9%
Covered Lines: 730
Relevant Lines: 759
💛 - Coveralls

@robertsLando
Copy link
Member Author

@mcollina CI will be broken until we don't release aedes-protocol-decoder to npm

@robertsLando
Copy link
Member Author

@mcollina

@robertsLando robertsLando mentioned this pull request Feb 4, 2020
Closed
mcollina
mcollina approved these changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit d166d32 into master Feb 4, 2020
@robertsLando robertsLando deleted the protocol-decoder branch February 4, 2020 13:35
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robertsLando @mcollina