Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test on broker.subscribe & broker.unsubscribe function #418

Merged
merged 5 commits into from Feb 11, 2020
Merged

Added test on broker.subscribe & broker.unsubscribe function #418

merged 5 commits into from Feb 11, 2020

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Feb 8, 2020

  • added tests
  • fixed typings

@gnought gnought added the bug label Feb 8, 2020
@gnought gnought requested a review from mcollina February 8, 2020 14:04
@gnought gnought mentioned this pull request Feb 10, 2020
Open
mcollina
mcollina approved these changes Feb 10, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnought gnought merged commit 5110824 into moscajs:master Feb 11, 2020
@gnought gnought deleted the hotfix/fix_param_type branch February 11, 2020 02:49
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnought @mcollina