Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user defined their error auth message #419

Merged
merged 1 commit into from Feb 9, 2020
Merged

Allow user defined their error auth message #419

merged 1 commit into from Feb 9, 2020

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Feb 9, 2020

  • User could define their own auth error message raised in clientError
  • no custom error message / empty error message will be applied to the internal one
  • User could define the CONNACK return code between 2 and 5. If out of ranges, 5 instead.

@gnought gnought requested a review from mcollina February 9, 2020 05:55
mcollina
mcollina approved these changes Feb 9, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnought gnought merged commit c2fd13c into moscajs:master Feb 9, 2020
@gnought gnought deleted the hotfix/allow_user_custom_error_msg branch February 9, 2020 09:47
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnought @mcollina