Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Max clients Id length option for MQTT 3.1.0 #435

Merged
merged 3 commits into from Feb 20, 2020
Merged

feat: Max clients Id length option for MQTT 3.1.0 #435

merged 3 commits into from Feb 20, 2020

Conversation

robertsLando
Copy link
Member

@github-actions
Copy link

Pull Request Test Coverage Report for Build 816ce4f0aff033db147b1b2ff650fa6f753e0cb3-PR-435

  • 0 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 9c90d2ef6ba7f4796258cbe16b4d6e0d6ea38e96: 0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@robertsLando robertsLando requested review from gnought and mcollina and removed request for gnought February 20, 2020 07:32
mcollina
mcollina approved these changes Feb 20, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit ade3c8a into master Feb 20, 2020
@robertsLando robertsLando deleted the feat-longerclientid branch February 20, 2020 16:59
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@gnought gnought gnought approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertsLando @mcollina @gnought