Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: publish to $SYS/ not allowed to prevent DoS #622

Merged
merged 4 commits into from Apr 22, 2021
Merged

fix: publish to $SYS/ not allowed to prevent DoS #622

merged 4 commits into from Apr 22, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Apr 21, 2021 •
edited

Fixes #597

Is this a breaking change in your opinion? @mcollina

@robertsLando robertsLando mentioned this pull request Apr 21, 2021
Closed
@coveralls
Copy link

coveralls commented Apr 21, 2021 •
edited

Pull Request Test Coverage Report for Build 770681307

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0004%) to 99.911%
Totals Coverage Status
Change from base Build 763934071: 0.0004%
Covered Lines: 800
Relevant Lines: 800
💛 - Coveralls

@robertsLando
Copy link
Member Author

@mcollina Ping?

GavinDmello
GavinDmello approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@GavinDmello GavinDmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@robertsLando robertsLando merged commit 353e0f8 into main Apr 22, 2021
@robertsLando robertsLando deleted the fix#597 branch April 22, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GavinDmello GavinDmello GavinDmello approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@gnought gnought Awaiting requested review from gnought

@getlarge getlarge Awaiting requested review from getlarge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] DoS Possibility if Client ID is known (Security)
3 participants
@robertsLando @coveralls @GavinDmello