This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Switching over to ioredis, to support Redis Cluster/Sentinel #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged with origin
|
This is on top of #449 |
| @@ -138,6 +138,22 @@ AbstractPersistence.prototype.wire = function(server) { | |||
| }; | |||
| }; | |||
|
|
|||
| function arrayFrom(object) { | |||
| return [].slice.call(object); | |||
| } | |||
There was a problem hiding this comment.
this will be terribly slow. Allocate a new array based on object.length and then add the stuff in there.
|
So, let's drop 0.10 from the supported versions, I'll bump the major. Probably we should also bump Ascoltatori to ioredis. |
Failed tests are related to mongoDB, no changes there... Is there any races in test suite? It feels temporarly failing @mcollina |
Merged
mcollina
added a commit
that referenced
this pull request
Jun 16, 2016
Merged manually #455 with v2-dev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains minimum changes required to work, later we can
refactor tests to use ioredis
use ioredis streamified scan instead of
keys *in loading ubscriptions