Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Foyer webpage #162

Merged
merged 6 commits into from
Aug 9, 2018
Merged

Conversation

justinGilmer
Copy link
Contributor

Provdided the basic RTD format that mBuild uses on its
github.io webpage.

Converted current markdown files to RST.

Added travis directives to generate these pages when a successful test
passes, like current mBuild functionality.

Modifications still need to be completed to make the site a bit more full-fledged.

Add more documentation for the actual data structures, etc. Adding that next.

Also document features of foyer like the residue templating, etc.

Provdided the basic RTD format that `mBuild` uses on its
github.io webpage.

Converted current markdown files to RST.

Added travis directives to generate these pages when a successful test
passes, like current `mBuild` functionality.
@justinGilmer justinGilmer added the WIP Work in Progress, not ready for merging label Mar 19, 2018
@justinGilmer justinGilmer self-assigned this Mar 19, 2018
@justinGilmer
Copy link
Contributor Author

Not ready for actual merging, just putting this here so others can pull and generate the HTML pages themselves as more changes are made.

@ctk3b
Copy link
Member

ctk3b commented May 29, 2018

Nice thanks for starting on this @justinGilmer.

Not sure if it's worth the time right now since this works just fine but I would like to try moving back to readthedocs at some point so we can remove the doc deploy process that we currently use.

@justinGilmer
Copy link
Contributor Author

Maybe I'm misunderstanding, but what is the difference between that and what we use now? I assumed RTD is just a theme for generating a website? Or does it contain more than that?

@ctk3b
Copy link
Member

ctk3b commented May 29, 2018

They do have a sphinx theme but they're also a service: https://readthedocs.org/

Every commit to master/tags/whatever-you-configure will create a new version of the docs and do all the sphinx build behind the scenes for you. We used to use it but ran into a lot of issues related to package installation. I think most of those have been resolved at this point but haven't fully re-evaluated

@summeraz summeraz added this to the 0.5 milestone May 30, 2018
@summeraz
Copy link
Contributor

summeraz commented Aug 9, 2018

We can obviously continue to improve this, but I think the website is at a point now where it's good to go.

@mattwthompson
Copy link
Member

Am I able to preview the site (at a webpage) before merging?

@summeraz
Copy link
Contributor

summeraz commented Aug 9, 2018

@mattwthompson Yes, you’ll have to add justinGilmer as a remote and fetch this branch.. Then navigate to the docs directory, run make html to generate the html files, and view the website with open _build/html/index.html.

@mattwthompson
Copy link
Member

Had to install a handful of packages but that worked, thanks.

Agree with your comment last night, this can be expanded on in the future but LGTM.

@summeraz summeraz merged commit 0fb1901 into mosdef-hub:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress, not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants