Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround function for applying nbfixes #268

Merged
merged 4 commits into from Oct 9, 2019

Conversation

mattwthompson
Copy link
Member

PR Summary:

Implements #267

@zijiewu3 this might be a more formal way of doing what we suggested for your cross-interactions, feel free to give this a shot or suggest any changes

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

Copy link
Contributor

@ahy3nz ahy3nz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed locally, code looks good. My only suggestion is checking that a1 and a2 actually get found before calling add_nbxfix?

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #268 into master will increase coverage by 2.91%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   85.76%   88.67%   +2.91%     
==========================================
  Files          10       11       +1     
  Lines        1138     1369     +231     
==========================================
+ Hits          976     1214     +238     
+ Misses        162      155       -7

@zijiewu3
Copy link

Thanks. I am going to give it a try.

@mattwthompson mattwthompson merged commit 408f03d into mosdef-hub:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants